fix(trie): reveal extension child in sparse trie when updating a leaf #13183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
added
C-bug
rkrasiuk
reviewed
Dec 9, 2024
crates/trie/sparse/src/trie.rs
Outdated
| *key = current.slice(current.len() - key.len()..common); | ||
|
|
||
| // Check if the extension node child is a hash that needs to be revealed | ||
| if self.nodes.get(¤t).unwrap().is_hash() { |
shekhirin
force-pushed
the
alexey/update-leaf-extension
branch
from
2d8c899 to
522273f
Compare
rkrasiuk
approved these changes
Dec 9, 2024
Comment on lines
+838
to
+840
| if self.updates.is_some() { | ||
| // Check if the extension node child is a hash that needs to be revealed | ||
| if self.nodes.get(¤t).unwrap().is_hash() { |
There was a problem hiding this comment.
surprised clippy does not complain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider the following scenario:
0x77853ecb3c80cc9dd0543d964574eefd6e89131a8e875c3606451dabd99ae6f40x77853ecwhich is an extension nodeExtension(ExtensionNode { key: Nibbles("0d"), child: "a04d1721cf2c8ae2649fffbf4c5bc6e71ac1646e592ff4bfeb3054aa4d56b69456" })0x77853ecb3c80cc9dd0543d964574eefd6e89131a8e875c3606451dabd99ae6f4and turn the extension node into a branch node, setting the old nibbledfrom the extension node in the state mask of the new branch node.The problem here is that the node under the nibble
dmay be a branch node that will need to appear in the hash mask of the newly created branch node, but we don't know if that's a branch node unless we reveal the extension node child.This PR reveals the original extension node child when we turn an extension node into a branch node with two children.