Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused trie-common alloy-serde dep #13201

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Dec 7, 2024

The alloy-serde dep is unused when just the arbitrary feature is present. The serde feature is enabled for alloy-rpc-types-eth alongside the dep when eip1186 is enabled, because otherwise the proof type does not exist.

cargo hack check --feature-powerset also now works.

@Rjected Rjected added C-enhancement New feature or request A-dependencies Pull requests or issues that are about dependencies A-trie Related to Merkle Patricia Trie implementation labels Dec 7, 2024
@mattsse mattsse added this pull request to the merge queue Dec 7, 2024
Merged via the queue into main with commit 7e9d2c1 Dec 7, 2024
42 checks passed
@mattsse mattsse deleted the dan/trie-common-unnecessary-dep branch December 7, 2024 05:15
lean-apple pushed a commit to lean-apple/reth that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Pull requests or issues that are about dependencies A-trie Related to Merkle Patricia Trie implementation C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants