chore: improve CompactZstd macro
#13277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
requested review from
joshieDo,
shekhirin,
Rjected,
emhane,
mattsse and
gakonst
as code owners
mattsse
approved these changes
Dec 10, 2024
| } | ||
|
|
||
| /// Adds `zstd` compression to derived [`Compact`]. | ||
| #[proc_macro_derive(CompactZstd, attributes(maybe_zero, reth_codecs))] | ||
| #[proc_macro_derive(CompactZstd, attributes(maybe_zero, reth_codecs, reth_zstd))] |
There was a problem hiding this comment.
adding reth_zstd makes sense, this a lot smarter than adding it to reth_codecs because then we don't run into the issue I had on my pr
| let is_zstd = true; | ||
| compact::derive(input, is_zstd) | ||
| let derive_input = { | ||
| let input = input.clone(); |
There was a problem hiding this comment.
wonder if we need to do this here or if we can do this
and get rid of the clone?
unsure though, we don't use zsdt derive a lot so this seems fine anyway
There was a problem hiding this comment.
Updated compact::derive to just accept a pre-parsed DeriveInput, we don't need clone that way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces some references to
bytescrate withreth_codecs::__private::bytesChanges
CompactZstdmacro to receive compressor and decompressor from user's input inreth_zstdattribute instead of expecting them to be available as{struct_name}_COMPRESSOR