-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(chain-state): MemoryOverlayStateProvider
as alias
#13285
Merged
DaniPopes
merged 9 commits into
paradigmxyz:main
from
aroralanuk:alias-memoryOverlayStateProvider
Dec 20, 2024
Merged
chore(chain-state): MemoryOverlayStateProvider
as alias
#13285
DaniPopes
merged 9 commits into
paradigmxyz:main
from
aroralanuk:alias-memoryOverlayStateProvider
Dec 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aroralanuk
requested review from
fgimenez,
mattsse and
rkrasiuk
as code owners
December 11, 2024 09:11
mattsse
reviewed
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ptal @DaniPopes
DaniPopes
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
This comment was marked as outdated.
This comment was marked as outdated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MemoryOverlayStateProvider
a 'static alias forMemoryOverlayStateProviderRef
and made all the StateProvider inline instead of theimpl_state_provider
macro.MemoryOverlayStateProvider
a type alias for the ref one #13280(It'll be a bit harder to review bc of moving the code but it's the same functions copied inline.)