Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(trie): parallel proof should return empty storage proofs #13300

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Dec 11, 2024

Same behavior as in non-parallel proof implementation

// Initialize all storage multiproofs as empty.
// Storage multiproofs for non empty tries will be overwritten if necessary.
let mut storages: B256HashMap<_> =
targets.keys().map(|key| (*key, StorageMultiProof::empty())).collect();

@shekhirin shekhirin added C-bug An unexpected or incorrect behavior A-trie Related to Merkle Patricia Trie implementation labels Dec 11, 2024
@shekhirin shekhirin marked this pull request as ready for review December 11, 2024 14:08
@shekhirin shekhirin enabled auto-merge December 11, 2024 14:08
Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good find, was not backported

@shekhirin shekhirin added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit 432e536 Dec 11, 2024
43 checks passed
@shekhirin shekhirin deleted the alexey/parallel-proof-empty-storages branch December 11, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-trie Related to Merkle Patricia Trie implementation C-bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants