Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use OpTypedTransaction directly #13350

Merged
merged 3 commits into from
Dec 12, 2024
Merged

chore: use OpTypedTransaction directly #13350

merged 3 commits into from
Dec 12, 2024

Conversation

klkvr
Copy link
Collaborator

@klkvr klkvr commented Dec 12, 2024

Based on #13317

We don't need wrapper type here if we just implement required traits under op feature flag

onbjerg
onbjerg reviewed Dec 12, 2024
View reviewed changes
Copy link
Member

@onbjerg onbjerg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these types exactly 1:1?

@klkvr
Copy link
Collaborator Author

klkvr commented Dec 12, 2024 •
edited
Loading

@onbjerg rn the OpTransaction is just a newtype wrapping OpTypedTransaction

reth/crates/optimism/primitives/src/transaction/mod.rs

Line 29 in 90fcfb9

pub struct OpTransaction(OpTypedTransaction);

Base automatically changed from klkvr/op-receipt to main December 12, 2024 14:02
@github-actions github-actions bot requested a review from gakonst as a code owner December 12, 2024 14:02
onbjerg
onbjerg approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant the on disk repr sorry, because this touches some codec code, but it looks ok on second look

@klkvr klkvr force-pushed the klkvr/use-op-alloy-tx branch from 1f2285c to 7b06f04 Compare December 12, 2024 14:05
@klkvr klkvr enabled auto-merge December 12, 2024 14:05
@klkvr klkvr added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit aef9023 Dec 12, 2024
42 checks passed
@klkvr klkvr deleted the klkvr/use-op-alloy-tx branch December 12, 2024 14:49
emhane pushed a commit to ethereum-optimism/op-reth that referenced this pull request Dec 13, 2024
@klkvr @emhane
chore: use OpTypedTransaction directly (paradigmxyz#13350)
c144ebc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onbjerg onbjerg onbjerg approved these changes

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@emhane emhane Awaiting requested review from emhane

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@gakonst gakonst Awaiting requested review from gakonst

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klkvr @onbjerg