fix(engine): return error on StateRootTask multiproof and root calculation failures #13356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgimenez
added
C-bug
fgimenez
requested review from
rkrasiuk,
mattsse,
Rjected and
gakonst
as code owners
shekhirin
approved these changes
Dec 12, 2024
| ))) | ||
| } | ||
| StateRootMessage::RootCalculationError(e) => { | ||
| return Err(ParallelStateRootError::Other(format!( |
There was a problem hiding this comment.
think we should introduce a custom error enum for the state root task, we seem to abuse the ParallelStateRootError::Other. can be done in a separate PR via a good first issue
There was a problem hiding this comment.
@shekhirin, this is a good idea. Can we create this custom error enum within the state root task?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The errors on multiproof and state root calculations are only logged, not returned. On errors the task just gets stuck.