Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed manual implementations of core::error::Error #13370

Merged
merged 12 commits into from
Dec 18, 2024
Merged

Removed manual implementations of core::error::Error #13370

merged 12 commits into from
Dec 18, 2024

Conversation

PelleKrab
Copy link
Contributor

@PelleKrab PelleKrab requested a review from gakonst as a code owner December 12, 2024 22:18
mattsse
mattsse requested changes Dec 14, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty,

some nits

crates/storage/errors/src/provider.rs Outdated Show resolved Hide resolved
crates/blockchain-tree-api/src/error.rs Outdated Show resolved Hide resolved
crates/storage/errors/src/provider.rs Outdated Show resolved Hide resolved
@PelleKrab PelleKrab requested a review from mattsse December 15, 2024 18:52
@mattsse mattsse added this pull request to the merge queue Dec 18, 2024
@mattsse mattsse added the C-debt Refactor of code section that is hard to understand or maintain label Dec 18, 2024
Merged via the queue into paradigmxyz:main with commit ef033ab Dec 18, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@emhane emhane Awaiting requested review from emhane

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove manual implementations of core::error::Error
2 participants
@PelleKrab @mattsse