Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: assert etl_config.file_size != 0 #13435

Merged
merged 1 commit into from
Dec 20, 2024
Merged

chore: assert etl_config.file_size != 0 #13435

merged 1 commit into from
Dec 20, 2024

Conversation

keroro520
Copy link
Contributor

Early fail when etl_config.file_size is incorrectly set.

@keroro520
chore: assert etl_config.file_size != 0
a5f143c 
early fail when etl_config.file_size is invalid
mattsse
mattsse approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reasonable

@mattsse mattsse added this pull request to the merge queue Dec 20, 2024
@mattsse mattsse added the A-db Related to the database label Dec 20, 2024
Merged via the queue into paradigmxyz:main with commit 04af678 Dec 20, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees
No one assigned
Labels
A-db Related to the database
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keroro520 @mattsse