Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(consensus): Add docs ab soon deprecated BeaconConsensusEngine #13439

Merged
merged 1 commit into from
Dec 20, 2024
Merged

chore(consensus): Add docs ab soon deprecated BeaconConsensusEngine #13439

merged 1 commit into from
Dec 20, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented Dec 19, 2024

@emhane emhane added C-docs An addition or correction to our documentation A-consensus Related to the consensus engine A-sdk Related to reth's use as a library labels Dec 19, 2024
Rjected
Rjected requested changes Dec 19, 2024
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestions are so that consumers know this will be deprecated as well

crates/consensus/beacon/src/engine/mod.rs Show resolved Hide resolved
@emhane emhane force-pushed the emhane/docs-soon-deprecated-beacon-consensus-engine branch from 43ff00a to 22599fe Compare December 20, 2024 11:52
@emhane emhane requested a review from Rjected December 20, 2024 11:53
Rjected
Rjected reviewed Dec 20, 2024
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, did not anticipate the clippy side effects, comment should actually be fine

@emhane emhane force-pushed the emhane/docs-soon-deprecated-beacon-consensus-engine branch from 22599fe to 5061694 Compare December 20, 2024 11:59
@emhane emhane enabled auto-merge December 20, 2024 12:00
@emhane emhane requested a review from Rjected December 20, 2024 12:00
Rjected
Rjected approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@emhane emhane added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit 0680675 Dec 20, 2024
84 of 85 checks passed
@emhane emhane deleted the emhane/docs-soon-deprecated-beacon-consensus-engine branch December 20, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Rjected approved these changes

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

Assignees
No one assigned
Labels
A-consensus Related to the consensus engine A-sdk Related to reth's use as a library C-docs An addition or correction to our documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emhane @Rjected