feat: SparseStateTrie's BlindedProviderFactory is boxed #13463
+10
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadtech-hub
requested review from
rkrasiuk,
Rjected and
shekhirin
as code owners
shekhirin
requested changes
Dec 20, 2024
There was a problem hiding this comment.
Clarified the original issue name, my bad.
What we want to do is to remove Boxes in StateRootTask that were introduced in #13294. The generici in SparseStateTrie can also be removed, but it's less invasive than in the task, so can be done later.
shekhirin
added
C-debt
|
@shekhirin |
Signed-off-by: nadtech-hub <taberlick@gmail.com>
Signed-off-by: nadtech-hub <taberlick@gmail.com>
|
@shekhirin I guess I got ur point. I will push changes in a while. Would you create a task for SparseStateTrie? Apparently, It will require much more changes. |
nadtech-hub
force-pushed
the
nadtech/boxing-provider-factory
branch
from
65ebec1 to
9056e24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should close 13307