Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: reuse build_import_pipeline for OP #13529

Merged
merged 1 commit into from
Dec 23, 2024
Merged

chore: reuse build_import_pipeline for OP #13529

merged 1 commit into from
Dec 23, 2024

Conversation

klkvr
Copy link
Collaborator

@klkvr klkvr commented Dec 23, 2024

fn in optimism-cli is identical to the one we have in cli-commands so this PR reuses the latter

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 23, 2024

CodSpeed Performance Report

Merging #13529 will degrade performances by 10.03%

Comparing klkvr/reuse-build-pipeline (18569ec) with main (3e15ae3)

Summary

❌ 1 regressions
✅ 76 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main klkvr/reuse-build-pipeline Change
❌ `receipts root size: 10 HashBuilder` 105.5 µs

mattsse
mattsse approved these changes Dec 23, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@mattsse mattsse added this pull request to the merge queue Dec 23, 2024
Merged via the queue into main with commit 5ea8f31 Dec 23, 2024
43 of 44 checks passed
@mattsse mattsse deleted the klkvr/reuse-build-pipeline branch December 23, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klkvr @mattsse