Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(simulate_v1): fill transactions sequentually #13532

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Conversation

klkvr
Copy link
Collaborator

@klkvr klkvr commented Dec 23, 2024

Closes #13531

Fills transactions one by one accounting for potential state changes.

Additionally updated the tx env construction to be done through EvmConfig by using the resolved transaction directly

@github-actions github-actions bot added A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior C-enhancement New feature or request labels Dec 23, 2024
Copy link

codspeed-hq bot commented Dec 23, 2024

CodSpeed Performance Report

Merging #13532 will not alter performance

Comparing klkvr/fix-simulate (1fbe25f) with main (8579c08)

Summary

✅ 73 untouched benchmarks
🆕 4 new benchmarks
⁉️ 4 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main klkvr/fix-simulate Change
🆕 `prefix set preload size: 1000 input size: 1000 BTreeSet with BTreeSet:range lookup`
🆕 `prefix set preload size: 1000 input size: 1000 BTreeSet with Iterator:any lookup`
🆕 `prefix set preload size: 1000 input size: 1000 Vec with binary search lookup`
🆕 `prefix set preload size: 1000 input size: 1000 Vec with custom cursor lookup`
⁉️ `prefix set preload size: 1000 input size: 999 BTreeSet with BTreeSet:range lookup`
⁉️ `prefix set preload size: 1000 input size: 999 BTreeSet with Iterator:any lookup`
⁉️ `prefix set preload size: 1000 input size: 999 Vec with binary search lookup`
⁉️ `prefix set preload size: 1000 input size: 999 Vec with custom cursor lookup`

@mattsse mattsse added this pull request to the merge queue Dec 23, 2024
Merged via the queue into main with commit 6822d4f Dec 23, 2024
43 of 44 checks passed
@mattsse mattsse deleted the klkvr/fix-simulate branch December 23, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resolve_transactions does not account for transactions from the same sender when populating the nonce
2 participants