Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: simplify revm specId mapping #13553

Merged
merged 1 commit into from
Dec 27, 2024
Merged

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Dec 25, 2024

now that we require TTD to know the activation block number, we no longer need to operate on Head and can instead operate on Header, although even just timestap + blocknumber is enough

simplified the optimism impl and removed all of the non optimism hardforks.

for OP timestamp is sufficient because the only block based hardfork is bedrock, and it is required that every OP chain supports bedrock

@mattsse mattsse requested a review from klkvr December 25, 2024 10:24
@mattsse mattsse added C-debt Refactor of code section that is hard to understand or maintain A-execution Related to the Execution and EVM labels Dec 25, 2024
Copy link

codspeed-hq bot commented Dec 25, 2024

CodSpeed Performance Report

Merging #13553 will degrade performances by 21.12%

Comparing matt/simplify-revm-specid-mapping (ff1bb07) with main (3fbb230)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 75 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main matt/simplify-revm-specid-mapping Change
`hash builder[init size 10000 update size 100 num updates 1]` 10 ms
`sparse trie[init size 10000 update size 100 num updates 3]` 10.1 ms

@mattsse mattsse enabled auto-merge December 25, 2024 13:09
Copy link
Member

@fgimenez fgimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse added this pull request to the merge queue Dec 27, 2024
auto-merge was automatically disabled December 27, 2024 11:20

Pull Request is not mergeable

Merged via the queue into main with commit d644900 Dec 27, 2024
43 of 44 checks passed
@mattsse mattsse deleted the matt/simplify-revm-specid-mapping branch December 27, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-execution Related to the Execution and EVM C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants