chore: correct typo docs #13557
Open
chore: correct typo docs #13557
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sky-coderay
requested review from
mattsse,
Rjected,
rkrasiuk and
fgimenez
as code owners
Rjected
requested changes
Dec 27, 2024
|
@Rjected All references have been updated, the project builds successfully. Thanks |
mattsse
approved these changes
Dec 28, 2024
| @@ -7,7 +7,7 @@ use alloy_primitives::{address, Address}; | |||
| pub static DAO_HARDFORK_BENEFICIARY: Address = address!("bf4ed7b27f1d666546e30d74d50d173d20bca754"); | |||
|
|
|||
| /// DAO hardfork account that ether was taken and added to beneficiary | |||
| pub static DAO_HARDKFORK_ACCOUNTS: [Address; 116] = [ | |||
| pub static DAO_HARDFORK_ACCOUNTS: [Address; 116] = [ | |||
There was a problem hiding this comment.
this rename has side effects. we also need to rename other occurrences of this constant
|
needs please don't open prs from main branch :) |
|
@mattsse I ran |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RCPtoRPCmesesagestomessagesDAO_HARDKFORK_ACCOUNTStoDAO_HARDFORK_ACCOUNTSI fixed the typos in the comments and also one in the function. I tried really hard—happy to help, thank you!