Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grammar and clarity in engine API comment #13573

Closed
wants to merge 1 commit into from

Conversation

mdqst
Copy link
Contributor

@mdqst mdqst commented Dec 28, 2024

I addressed a grammatical issue and improved the clarity of a key comment related to the engine API payload builder.

Changes Made:

  1. Corrected the verb form from "launch" to "launches" to ensure grammatical agreement with the subject.
  2. Added a comma after "node" to improve readability.
  3. Clarified the phrase "with our custom" by completing it as "with our custom one."

The revised comment now reads:

//! This launches the regular reth node, overriding the engine API payload builder with our custom one.  

I believe this adjustment improves both readability and accuracy, ensuring the intent is clear for anyone reading or maintaining the code.

@mdqst mdqst requested a review from gakonst as a code owner December 28, 2024 09:48
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo fix prs are currently no longer accepted

@mattsse mattsse closed this Dec 28, 2024
Copy link

codspeed-hq bot commented Dec 28, 2024

CodSpeed Performance Report

Merging #13573 will degrade performances by 10.45%

Comparing mdqst:patch-4 (b5acbfa) with main (91dd417)

Summary

❌ 1 regressions
✅ 76 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main mdqst:patch-4 Change
`hash builder[init size 10000 update size 100 num updates 1]` 9.1 ms

@mdqst mdqst deleted the patch-4 branch December 28, 2024 10:22
@mdqst
Copy link
Contributor Author

mdqst commented Dec 28, 2024

mattsse, gakonst, I understand that you will most likely not respond to me, but what a foolishness this is. I am trying to improve the project, but my efforts are simply being ignored. You are a very disloyal project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants