feat: add receipt builder for OpExecutionStrategy
#13792
Merged
+279
−108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
requested review from
mattsse,
Rjected,
fgimenez and
gakonst
as code owners
mattsse
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
this will conflict a bit with #13735 but I don't mind rebasing that a few times hehe
Comment on lines
+214
to
+215
| /// Trait for deposit receipt. | ||
| pub trait DepositReceipt: reth_primitives_traits::Receipt { |
There was a problem hiding this comment.
I think we can live with this returning Option and we expect that this will be implemented for the actual receipt enum, so no need to to also name this OpReceipt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR experiments with an idea of OP rollup with custom transaction type. RIght now
OpExecutionStrategyexpects concreteOpTransactionSignedand changing it would require making tx -> receipt conversion configurable.This is solved with an additional
OpReceiptBuildertrait