Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(book): add consensus layer explanation in book #3413

Merged
merged 1 commit into from
Jun 26, 2023
Merged

feat(book): add consensus layer explanation in book #3413

merged 1 commit into from
Jun 26, 2023

Conversation

tcoratger
Copy link
Contributor

@tcoratger tcoratger commented Jun 26, 2023 •
edited by onbjerg
Loading

Closes #3391

@tcoratger tcoratger requested a review from gakonst as a code owner June 26, 2023 17:50
@onbjerg onbjerg added C-docs An addition or correction to our documentation C-enhancement New feature or request labels Jun 26, 2023
onbjerg
onbjerg approved these changes Jun 26, 2023
View reviewed changes
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, ty

@onbjerg onbjerg enabled auto-merge June 26, 2023 17:51
@codecov
Copy link

codecov bot commented Jun 26, 2023 •
edited
Loading

Codecov Report

Merging #3413 (306b8e3) into main (30a1ad2) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3413      +/-   ##
==========================================
- Coverage   69.40%   69.33%   -0.07%     
==========================================
  Files         537      537              
  Lines       72018    72034      +16     
==========================================
- Hits        49981    49944      -37     
- Misses      22037    22090      +53
Flag Coverage Δ
integration-tests 16.35% <ø> (+0.02%) ⬆️
unit-tests 64.38% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 44 files with indirect coverage changes

@onbjerg onbjerg added this pull request to the merge queue Jun 26, 2023
Merged via the queue into paradigmxyz:main with commit 5a1d58a Jun 26, 2023
25 checks passed
@tcoratger tcoratger deleted the consensus-book branch July 3, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onbjerg onbjerg onbjerg approved these changes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
C-docs An addition or correction to our documentation C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clearly explain consensus/execution split in book
2 participants
@tcoratger @onbjerg