feat: don't stop the pipeline on internal stage errs #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onbjerg
added
C-enhancement
Codecov Report
@@ Coverage Diff @@
## main #453 +/- ##
=======================================
Coverage ? 74.09%
=======================================
Files ? 239
Lines ? 23225
Branches ? 0
=======================================
Hits ? 17208
Misses ? 6017
Partials ? 0
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Discussion on whether |
onbjerg
force-pushed
the
onbjerg/pipeline-stage-errs
branch
from
9a66b07 to
5a8ad6c
Compare
gakonst
approved these changes
Dec 15, 2022
| @@ -21,6 +21,7 @@ pub enum StageError { | |||
| Database(#[from] DbError), | |||
| #[error("Stage encountered a execution error in block {block}: {error}.")] | |||
| /// The stage encountered a execution error | |||
| // TODO: Probably redundant, should be rolled into `Validation` | |||
| @@ -28,6 +28,7 @@ pub struct SendersStage { | |||
| pub commit_threshold: u64, | |||
| } | |||
|
|
|||
| // TODO(onbjerg): Should unwind | |||
There was a problem hiding this comment.
All cases I think. If we can't recover the sender then the transaction is invalid (assuming our recover algo is not broken)
Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differentiate between fatal errors that should stop the pipeline because no progress can be made, and errors that are recoverable. Stages should feel free to emit errors to make unit testing them easier, and the pipeline should catch them, evaluate if they are fatal or not and act accordingly