Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Alloy migration #4737

Merged
merged 27 commits into from
Sep 28, 2023
Merged

feat: Alloy migration #4737

merged 27 commits into from
Sep 28, 2023

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Sep 23, 2023 •
edited
Loading

Migrate all primitive types, ABI, RLP, and EIP-712 logic to Alloy.

See tracking issue #4715.

This was referenced Sep 23, 2023
Merged
Closed
Closed
Closed
Closed
Closed
@codecov

This comment was marked as outdated.

Sign in to view
@DaniPopes DaniPopes mentioned this pull request Sep 23, 2023
Closed
@DaniPopes DaniPopes added the C-enhancement New feature or request label Sep 23, 2023
This was referenced Sep 23, 2023
Merged
Closed
@DaniPopes DaniPopes self-assigned this Sep 23, 2023
@DaniPopes DaniPopes mentioned this pull request Sep 23, 2023
Merged
This was referenced Sep 25, 2023
Closed
Merged
Merged
@tcoratger tcoratger mentioned this pull request Sep 25, 2023
Merged
@DaniPopes DaniPopes mentioned this pull request Sep 26, 2023
Closed
@DaniPopes DaniPopes marked this pull request as ready for review September 28, 2023 00:13
mattsse
mattsse approved these changes Sep 28, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

awesome work!

@DaniPopes
Copy link
Member Author

cc @gakonst

@Rjected Rjected mentioned this pull request Sep 28, 2023
Merged
@mattsse
Copy link
Collaborator

mattsse commented Sep 28, 2023

@DaniPopes new conflicts -.-

@DaniPopes
Copy link
Member Author

DaniPopes commented Sep 28, 2023 •
edited
Loading

Needs also bluealloy/revm#724 rebase
Using Evalir/revm#4 for now

gakonst
gakonst approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

send it once conflicts resolved. amazing...

@DaniPopes DaniPopes added this pull request to the merge queue Sep 28, 2023
Merged via the queue into main with commit 5f9a917 Sep 28, 2023
24 checks passed
@DaniPopes DaniPopes deleted the alloy branch September 28, 2023 16:09
@supernovahs supernovahs mentioned this pull request Nov 15, 2023
Merged
@bocalhky bocalhky mentioned this pull request Jun 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@gakonst gakonst gakonst approved these changes

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees

@DaniPopes DaniPopes

Labels
C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DaniPopes @mattsse @gakonst @alessandromazza98 @supernovahs