Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docker): disable jemalloc feature by default #6495

Merged
merged 1 commit into from
Feb 8, 2024
Merged

fix(docker): disable jemalloc feature by default #6495

merged 1 commit into from
Feb 8, 2024

Conversation

DaniPopes
Copy link
Member

See https://t.me/paradigm_reth/21284

Jemalloc is not portable due to compiled-in page size: jemalloc/jemalloc#467

@DaniPopes DaniPopes requested review from onbjerg and mattsse February 8, 2024 21:29
@DaniPopes DaniPopes requested a review from gakonst as a code owner February 8, 2024 21:29
mattsse
mattsse reviewed Feb 8, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this means we can never safely include jemalloc in docker?

so disabling sgtm

@mattsse mattsse added the A-meta Changes in the contributor workflow and planning label Feb 8, 2024
onbjerg
onbjerg approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DaniPopes DaniPopes added this pull request to the merge queue Feb 8, 2024
Merged via the queue into main with commit e56a520 Feb 8, 2024
29 checks passed
@DaniPopes DaniPopes deleted the dani/jemalloc-dockerfile branch February 8, 2024 21:55
@jtraglia jtraglia mentioned this pull request Feb 22, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse left review comments

@onbjerg onbjerg onbjerg approved these changes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-meta Changes in the contributor workflow and planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DaniPopes @onbjerg @mattsse