feat: integrate builder #6611
Merged
feat: integrate builder #6611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rjected
reviewed
Feb 14, 2024
gakonst
reviewed
Feb 14, 2024
gakonst
reviewed
Feb 14, 2024
onbjerg
reviewed
Feb 15, 2024
gakonst
reviewed
Feb 15, 2024
gakonst
reviewed
Feb 15, 2024
gakonst
reviewed
Feb 15, 2024
gakonst
reviewed
Feb 15, 2024
Rjected
reviewed
Feb 15, 2024
gakonst
reviewed
Feb 15, 2024
gakonst
reviewed
Feb 15, 2024
gakonst
reviewed
Feb 15, 2024
Rjected
approved these changes
Feb 16, 2024
Comment on lines
+313
to
+314
| <reth_ethereum_payload_builder::EthereumPayloadBuilder as PayloadBuilder<Pool,Client>> ::build_empty_payload(client, | ||
| PayloadConfig { initialized_block_env, initialized_cfg, parent_block, extra_data, attributes: attributes.0, chain_spec } |
There was a problem hiding this comment.
any way to make the formatting on this better?
|
and pending compile fixes |
mattsse
force-pushed
the
matt/integrate-node-builder
branch
from
3ebf539 to
cd494ba
Compare
This was referenced Feb 22, 2024
rkrasiuk
approved these changes
Feb 29, 2024
| } | ||
|
|
||
| /// Creates an _ephemeral_ preconfigured node for testing purposes. | ||
| pub fn testing_node( |
| @@ -14,7 +21,34 @@ fn main() { | |||
| std::env::set_var("RUST_BACKTRACE", "1"); | |||
| } | |||
|
|
|||
| if let Err(err) = reth::cli::run() { | |||
| if let Err(err) = Cli::<RollupArgs>::parse().run(|builder, rollup_args| async move { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrates the new builder API.
Removes all extension trait stuff
the launch code is now part of the builder
I've also modified the
receipt_rootfunctions because mutually exclusive function signatures are a nightmare if we use conflicting ethereum code by defaultone example is not completely ported, but I think this didn't even work previously, would like to tackle this in a followup because requires more work.