Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable jemalloc when cross-building aarch64 #6766

Merged
merged 1 commit into from
Feb 24, 2024

Conversation

jtraglia
Copy link
Contributor

This PR will disable jemalloc when cross-building the binary for aarch64-unknown-linux-gnu.

This reth binary is used here:

reth/Makefile

Lines 197 to 212 in 21bc1a8

define build_docker_image
$(MAKE) build-x86_64-unknown-linux-gnu
mkdir -p $(BIN_DIR)/amd64
cp $(BUILD_PATH)/x86_64-unknown-linux-gnu/$(PROFILE)/reth $(BIN_DIR)/amd64/reth
$(MAKE) build-aarch64-unknown-linux-gnu
mkdir -p $(BIN_DIR)/arm64
cp $(BUILD_PATH)/aarch64-unknown-linux-gnu/$(PROFILE)/reth $(BIN_DIR)/arm64/reth
docker buildx build --file ./Dockerfile.cross . \
--platform linux/amd64,linux/arm64 \
--tag $(DOCKER_IMAGE_NAME):$(1) \
--tag $(DOCKER_IMAGE_NAME):$(2) \
--provenance=false \
--push
endef

And correct binary is selected here:

COPY ./dist/bin/$TARGETARCH/reth /usr/local/bin/reth

Fixes #6742.

Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaniPopes DaniPopes added this pull request to the merge queue Feb 24, 2024
Merged via the queue into paradigmxyz:main with commit 5cb0258 Feb 24, 2024
29 checks passed
@jtraglia jtraglia deleted the disable-jemalloc-aarch64-cross branch February 24, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with jemalloc on system with larger page size
4 participants