Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(op-reth): non-deposit txs have depositReceiptVersion=1 #6784

Merged
merged 14 commits into from
Mar 12, 2024
Merged

fix(op-reth): non-deposit txs have depositReceiptVersion=1 #6784

merged 14 commits into from
Mar 12, 2024

Conversation

0xZerohero
Copy link
Contributor

Fixes #6604

@0xZerohero 0xZerohero marked this pull request as ready for review February 26, 2024 13:01
@mattsse mattsse requested a review from Rjected February 26, 2024 14:09
@mattsse mattsse added C-test A change that impacts how or what we test A-op-reth Related to Optimism and op-reth labels Feb 26, 2024
mattsse
mattsse requested changes Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

this untangles the evm tests from node-ethereum, which is nice.

pta closer look @Rjected

crates/revm/src/optimism/processor.rs Outdated Show resolved Hide resolved
crates/revm/src/optimism/processor.rs Show resolved Hide resolved
Rjected
Rjected requested changes Mar 5, 2024
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mainly have a nit about semicolons, otherwise this looks good to me. when we improve the processor / executor abstraction, the tests can then be moved to the node-ethereum and node-optimism crates. Then we won't need the test config any more

crates/revm/src/test_utils.rs Show resolved Hide resolved
crates/revm/src/test_utils.rs Show resolved Hide resolved
crates/revm/src/processor.rs Outdated Show resolved Hide resolved
@mattsse mattsse requested a review from Rjected March 12, 2024 16:20
Rjected
Rjected approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks!

@Rjected Rjected requested review from mattsse and removed request for mattsse March 12, 2024 16:39
@mattsse mattsse enabled auto-merge March 12, 2024 16:45
@mattsse mattsse added this pull request to the merge queue Mar 12, 2024
Merged via the queue into paradigmxyz:main with commit fb30619 Mar 12, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clabby clabby clabby left review comments

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Rjected approved these changes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-op-reth Related to Optimism and op-reth C-test A change that impacts how or what we test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Non-deposit transactions have depositReceiptVersion=1
4 participants
@0xZerohero @Rjected @clabby @mattsse