chore(primitives): remove static file stage #7116
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup after #6763
This PR does not remove the
StageId::StaticFile
variant, as it's unclear whether it's a breaking database change.check_pipeline_consistency
has a strong assumption that the first stage of the pipeline isHeaders
reth/crates/consensus/beacon/src/engine/mod.rs
Lines 557 to 598 in 027d50f
But because we had
StaticFile
as the first stage without an actual stage implementation, its checkpoint was always zero, so the consistency check passed, and the node went to live sync instead of continuing the pipeline sync.