fix: tell jemalloc to use 64-KiB pages when cross building aarch64 #7123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onbjerg
requested changes
Mar 13, 2024
Sure, I can look into that. Might not be so easy in the Makefile. |
jtraglia
changed the title
|
cc @onbjerg when you have time to review |
onbjerg
approved these changes
Mar 19, 2024
Ruteri
pushed a commit
to Ruteri/reth
that referenced
this pull request
Apr 17, 2024
Ruteri
pushed a commit
to Ruteri/reth
that referenced
this pull request
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6742.
This PR sets
JEMALLOC_SYS_WITH_LG_PAGEto 16 for aarch64 cross builds, which will force jemalloc to use 64 KiB pages. This should work with most of the newer arm64 systems which use larger pages. This is an alternative to:I have tested this myself by running
make docker-build-pushon an x86_64 system. I pulled the image (which I pushed to my local docker hub account) on my M1 Mac mini running Linux and it works.Initially, setting the environment variable didn't seem to work. I realized that environment variables weren't being passed to
cross build, which makes sense because it's a docker container. I had to configure passthrough variables.Link: https://docs.rs/crate/cross/0.1.14
This PR also re-enables jemalloc to be a default feature.