Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: feature gate rpc-types import for alloy conversions #7963

Merged
merged 3 commits into from
May 8, 2024
Merged

feat: feature gate rpc-types import for alloy conversions #7963

merged 3 commits into from
May 8, 2024

Conversation

andrzejSulkowski
Copy link
Contributor

Issue: #7906

@onbjerg onbjerg changed the title feature gate rpc-types import for alloy conversions feat: feature gate rpc-types import for alloy conversions Apr 29, 2024
@onbjerg onbjerg added C-enhancement New feature or request A-rpc Related to the RPC implementation C-debt Refactor of code section that is hard to understand or maintain and removed C-enhancement New feature or request labels Apr 29, 2024
mattsse
mattsse approved these changes May 3, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,

I'm blocking this until we can move away from alloy-rpc types as a dep

@mattsse mattsse added the S-blocked This cannot more forward until something else changes label May 3, 2024
@andrzejSulkowski andrzejSulkowski requested a review from Rjected as a code owner May 8, 2024 20:25
mattsse
mattsse approved these changes May 8, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, we can now make rpc-types entirely optional

fyi @tcoratger conversions now require alloy-compat feature

@mattsse mattsse added this pull request to the merge queue May 8, 2024
Merged via the queue into paradigmxyz:main with commit dd7c021 May 8, 2024
29 checks passed
mw2000 pushed a commit to mw2000/reth that referenced this pull request Jun 5, 2024
@andrzejSulkowski @mattsse @mw2000
feat: feature gate rpc-types import for alloy conversions (paradigmxy…
dc91af1 
…z#7963)

Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation C-debt Refactor of code section that is hard to understand or maintain S-blocked This cannot more forward until something else changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrzejSulkowski @mattsse @onbjerg