feat: Add example for custom rlpx subprotocol #8113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onbjerg
changed the title
onbjerg
reviewed
May 5, 2024
mattsse
requested changes
May 6, 2024
| use tokio_stream::wrappers::UnboundedReceiverStream; | ||
|
|
||
| // Custom Rlpx Subprotocol | ||
| pub mod proto { |
There was a problem hiding this comment.
can we move this to a separate file?
Comment on lines
279
to
280
| // let custom_rlpx_handler = CustomRlpxProtoHandler{ state: ProtocolState { events: node.network.events.clone()}}; | ||
| // node.network.add_rlpx_sub_protocol(custom_rlpx_handler); |
gakonst
reviewed
May 6, 2024
Comment on lines
+170
to
+177
| enum Command { | ||
| /// Send a custom message to the peer | ||
| CustomMessage { | ||
| msg: String, | ||
| /// The response will be sent to this channel. | ||
| response: oneshot::Sender<String>, | ||
| }, | ||
| } |
There was a problem hiding this comment.
@mattsse this is cool -- we should demonstrate a bridge/oracle on this, and eventually build up to a full consensus example i feel?
and this is all subprotocols for commands post-establishing a connection, but what about discv? how should we do discovery of nodes that support custom subprotocols?
There was a problem hiding this comment.
tracking here #8017
for this we need a more sophisticated example
|
@owanikin I rebased this, but this still needs the required protocol trait implementations |
gakonst
reviewed
Jun 13, 2024
|
Hi @owanikin are you still on this? I d like to get it. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am creating this draft pr to solicit feedback on: 1) If I am on the right track. 2) pointers/direction on how to really solve the issue. Thanks for your help.
Closes #7130