feat: add launch_with_fn #8694
Merged
feat: add launch_with_fn #8694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
added
C-enhancement
onbjerg
reviewed
Jun 10, 2024
| @@ -220,6 +220,14 @@ impl<T: FullNodeTypes, CB: NodeComponentsBuilder<T>> NodeBuilderWithComponents<T | |||
| launcher.launch_node(self).await | |||
| } | |||
|
|
|||
| /// Launches the node with the given closure. | |||
| pub fn launch_with_fn<L, R>(self, launcher: L) -> R | |||
There was a problem hiding this comment.
what is the difference between this and launch_with(closure) given closures now impl LaunchNode?
There was a problem hiding this comment.
this supports arbitrary logic and supports launch functions as closures and helps with type hints, otherwise the user would need to provide type hints explicitly on launch_node
onbjerg
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
provides a way to use closure launchers and implement LaunchNode for closures