Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rpc): move message signing to EthTransactions #8759

Merged
merged 68 commits into from
Jun 12, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented Jun 11, 2024

Moves singing of messages to default impl of EthTransactions

This clears the final blocker to allow impl for all type that meet trait bounds, however this means the declaration needs to move into reth_rpc crate, as can only be impl for generic type, if defined in same crate, so we need to think ab that @mattsse

impl<T> EthApiServer for T
where
    T: EthApiSpec
        + EthTransactions
        + EthBlocks
        + EthState
        + EthCall
        + EthFees
        + LoadReceipt
        + Trace,
{ .. }

@emhane emhane added C-debt Refactor of code section that is hard to understand or maintain A-rpc Related to the RPC implementation A-op-reth Related to Optimism and op-reth labels Jun 11, 2024
@emhane emhane changed the base branch from main to matt/scaffold-ethapi June 11, 2024 18:10
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, this is really taking shape now

@emhane emhane merged commit e4f9fdc into matt/scaffold-ethapi Jun 12, 2024
24 of 31 checks passed
@emhane emhane deleted the emhane/ethapi-signer branch June 12, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-op-reth Related to Optimism and op-reth A-rpc Related to the RPC implementation C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants