I'm tired of wrestling with this.

We conditionally define random_bytes() and fallback to an implementation that ALWAYS throws an Exception. However, in libraries that consume random_compat, we want the type hint to always be a string. So, I'm done. Suppress the damn error (but still print it) and let's move on with our lives.
paragonie · Jun 6, 2018 · cbe0b11 · cbe0b11
1 parent 71883fb
commit cbe0b11
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/lib/random.php b/lib/random.php
@@ -204,6 +204,7 @@ class_exists('COM')
          *
          * @param mixed $length
          * @psalm-suppress MissingReturnType
+         * @psalm-suppress InvalidReturnType
          * @throws Exception
          * @return string
          */

diff --git a/psalm.xml b/psalm.xml
@@ -14,5 +14,6 @@
         <InvalidOperand errorLevel="info" />
         <UndefinedConstant errorLevel="info" />
         <MissingReturnType errorLevel="info" />
+        <InvalidReturnType errorLevel="info" />
     </issueHandlers>
 </psalm>