Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add polyfill tag #139

Merged
merged 1 commit into from
May 22, 2018
Merged

Add polyfill tag #139

merged 1 commit into from
May 22, 2018

Conversation

theofidry
Copy link
Contributor

This allows this package to be found when looking at the polyfill(s) tagged Composer packages

@narfbg
Copy link

narfbg commented Apr 28, 2018

I'd also add "compat" to that.

@theofidry
Copy link
Contributor Author

Is it used though? Most of the polyfills in the wild are from Symfony and none of them are tagged as "compat" :/

@narfbg
Copy link

narfbg commented Apr 28, 2018

If I was looking for such a package, I'd search for "compat" instead of "polyfill" - that's what I'm saying.

@svenluijten
Copy link

svenluijten commented May 22, 2018

@narfbg this package is already the first result when searching for "compat" on https://packagist.org, what would an extra keyword do?

screenshot

@glensc
Copy link
Contributor

glensc commented May 22, 2018

but if you search "polyfill", it's third

image

as you see the description matches "polyfill" so i think it's fair to include it in keywords too.

@paragonie-scott paragonie-scott merged commit 71883fb into paragonie:master May 22, 2018
@paragonie-scott
Copy link
Member

Keywords cost us nothing, so, I'm okay with including both.

@theofidry theofidry deleted the patch-1 branch May 22, 2018 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants