Filename as window title #2500
Merged
Filename as window title #2500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Display the filename as the new window's title in 'dataurlnewwindow' case.
src/jspdf.js
Outdated
| @@ -2423,7 +2423,8 @@ var jsPDF = (function (global) { | |||
| * | |||
| * If `type` argument is undefined, output is raw body of resulting PDF returned as a string. | |||
| * | |||
| * @param {string} type A string identifying one of the possible output types. Possible values are 'arraybuffer', 'blob', 'bloburi'/'bloburl', 'datauristring'/'dataurlstring', 'datauri'/'dataurl', 'dataurlnewwindow', 'pdfobjectnewwindow', 'pdfjsnewwindow'. | |||
| * @param {string} type A string identifying one of the possible output types. Possible values are 'arraybuffer', 'blob', 'bloburi'/'bloburl', 'datauristring'/'dataurlstring', 'datauri'/'dataurl', 'dataurl | |||
There was a problem hiding this comment.
Please fix the comment
src/jspdf.js
Outdated
| @@ -2939,7 +2939,7 @@ var jsPDF = (function(global) { | |||
| * | |||
| * If `type` argument is undefined, output is raw body of resulting PDF returned as a string. | |||
| * | |||
| * @param {string} type A string identifying one of the possible output types. Possible values are 'arraybuffer', 'blob', 'bloburi'/'bloburl', 'datauristring'/'dataurlstring', 'datauri'/'dataurl', 'dataurl | |||
| * @param {string} type A string identifying one of the possible output types. Possible values are 'arraybuffer', 'blob', 'bloburi'/'bloburl', 'datauristring'/'dataurlstring', 'datauri'/'dataurl', 'dataurlnewwindow', 'pdfobjectnewwindow', 'pdfjsnewwindow'. | |||
| ', 'pdfobjectnewwindow', 'pdfjsnewwindow'. | |||
There was a problem hiding this comment.
sorry for nitpicking, but now 'pdfobjectnewwindow', 'pdfjsnewwindow' appear twice ;)
There was a problem hiding this comment.
Ah, thanks for catching that!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display the filename as the new window's title in 'dataurlnewwindow' case.
Fixes #2499