-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multiline text not preserved when using "maxWidth" property #2942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
listopadiya
commented
Oct 4, 2020
HackbrettXXX
approved these changes
Oct 5, 2020
This was referenced Mar 10, 2021
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem when using multiline text and
maxWidth
text property simultameously,maxWidth
was kind of rewriting existing text line splitting. It could be seen with multiline text inside table cell (#2891) or just with ordinary text like this:With this PR lines of text defined by user are preserved when putting width restriction on them. It works for both multiline-as-an-array and multiline-as-formatted-with-linebreak-symbols texts. Also cell line height calculation was fixed, so that it works for both variants described above.
There is String Splitting example in live demo, it works correctly, but looks like it uses
splitTextToSize
method directly.Basic checks done:
npm run test-local
pass except one test (which is not passing in master branch for me as well, so probably it is my local browser-related problem or whatever)