Add functions to encrypt PDFs for pdf version 1.3 #2959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I will review this next week, because I'm very busy this week. But no worries, we will get through with this before the 31st ;) |
|
Sure, no problem. Meanwhile I'll try to figure out why the tests are failing |
|
Hi @HackbrettXXX any chance of checking this out this week? |
HackbrettXXX
requested changes
Oct 20, 2020
There was a problem hiding this comment.
- Please revert the changes to the files in the dist folder. They are only updated on release.
- Please add the encryption options also to the types/index.d.ts file and add a test case types/jspdf.test.ts
- Please also add a unit test with a reference PDF.
- Just to be sure: did you check that every string outside a content stream is encrypted, as well?
|
For the strings outside the content stream, so far I have tested with most of the examples. Works for all so far except the acroforms one. I will need to work on that. |
|
Perhaps moving forward the outtputing functions might need a refactor? For instance outputting a dict is something common across many modules, so they should all output using a standard interface, which would allow encapsulation for the encryption part. |
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2750 Implement PDF encryption Version 1 Revision 2 for PDF version 1.3. By default the PDF is not encrypted, encryption can be enabled in the options passed when creating the PDF.
The encryption key for streams and string fields depends on a objectId. Thus, the putStream function now takes in an objectId as one of its options. If encryption is not enabled, then the objectId is not required, hence the API is still backward compatible. If encryption is enabled but the objectId is not passed in then an error is thrown.