context2d: Fix default font behavior. #3316
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I've encountered an inconsistency of context2d text rendering.
Previous, if you used contex2d to "fillText" (with default font) on the first page, the current jsPDF font (and size) was used (not the context2d font). However, if you then "fillText" on the next page, suddenly the context2d font will be used. So you end up with text rendered in different fonts.
I propose with this PR that if you access the context2d for the first time, that we force apply the context2d font as the current jsPDF font. This makes rendering text consistent.
Of course, if someone changes the jsPDF font in the meantime, the problem is back. But I think this is a complete other topic. And a mix between two rendering methods are probably not that common.
Regards
Thomas