Modify configuration to have provider-specific structs #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anton Antonov <Anton.Antonov@arm.com>
hug-dev
reviewed
Feb 26, 2020
There was a problem hiding this comment.
Excellent changes! A few things I particularly like:
- very good and original idea to use a enum composed of struct
- removing the
Optionmakes the code much more simple - I did not even know that you could ignore some fields when matching a enum of structs 💥
Just a small comment about the serde attribute
Signed-off-by: Anton Antonov <Anton.Antonov@arm.com>
hug-dev
approved these changes
Feb 27, 2020
Comment on lines
+30
to
+33
| // For providers configs in parsec config.toml we use a format similar | ||
| // to the one described in the Internally Tagged Enum representation | ||
| // where "provider_type" is the tag field. For details see: | ||
| // https://serde.rs/enum-representations.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Enums of structs with provider specific options instead of a common struct.
Checks for missing parameters are not required in get_provider any more because it's done while parsing the config file into enums.
This change covers #70 and #103