Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to remove const_err #653

Merged
merged 2 commits into from
Jan 4, 2023
Merged

Update to remove const_err #653

merged 2 commits into from
Jan 4, 2023

Conversation

marcsvll
Copy link
Contributor

This PR only removed const_err since it will be a hard error in future: rust-lang/rust#71800

Signed-off-by: Marcus de Lima marcus.lima@azion.com

@marcsvll
Update lib.rs and main.rs to remove const_err
078ea03 
Signed-off-by: Marcus de Lima <marcus.lima@azion.com>
@marcsvll marcsvll requested a review from a team as a code owner December 23, 2022 09:32
@marcsvll
Remove const_err from tests files
86a71cd 
Signed-off-by: Marcus de Lima <marcus.lima@azion.com>
@marcsvll marcsvll changed the title Update lib.rs and main.rs to remove const_err Update to remove const_err Dec 23, 2022
paulhowardarm
paulhowardarm approved these changes Jan 3, 2023
View reviewed changes
Copy link
Collaborator

@paulhowardarm paulhowardarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the PR. This looks like the correct change, as far as I understand the history behind it.

@gowthamsk-arm
Copy link
Contributor

Thanks for the PR. LGTM.

@gowthamsk-arm gowthamsk-arm merged commit 199285b into parallaxsecond:main Jan 4, 2023
adamjohnstonarm
adamjohnstonarm reviewed Jan 4, 2023
View reviewed changes
Copy link

@adamjohnstonarm adamjohnstonarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamjohnstonarm adamjohnstonarm adamjohnstonarm left review comments

@gowthamsk-arm gowthamsk-arm gowthamsk-arm approved these changes

@paulhowardarm paulhowardarm paulhowardarm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marcsvll @gowthamsk-arm @adamjohnstonarm @paulhowardarm