rename accured to accrued. #1651
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1651 +/- ##
==========================================
- Coverage 70.44% 70.01% -0.43%
==========================================
Files 115 115
Lines 12866 12971 +105
==========================================
+ Hits 9063 9082 +19
- Misses 3803 3889 +86
Continue to review full report at Codecov.
|
| @@ -131,7 +131,7 @@ impl<T: Config> Pallet<T> { | |||
| .ok_or(ArithmeticError::Underflow)?; | |||
| *supplier_index = supply_state.index; | |||
|
|
|||
| RewardAccured::<T>::try_mutate(supplier, |total_reward| -> DispatchResult { | |||
| RewardAccrued::<T>::try_mutate(supplier, |total_reward| -> DispatchResult { | |||
There was a problem hiding this comment.
Unfortunately, we need migration.
|
|
Local test log: |
| frame_support::generate_storage_alias!(Loans, RewardAccured<T: Config> => Map< | ||
| (Blake2_128Concat, T::AccountId), | ||
| BalanceOf<T> | ||
| >); | ||
|
|
||
| #[cfg(feature = "try-runtime")] |
There was a problem hiding this comment.
@GopherJ one question maybe not related to this pr, why we enable try-runtime feature in production release?
There was a problem hiding this comment.
@yrong at the beginning we would like to have a full featured binary so we enabled all
|
paritytech/substrate#9016 |
|
yeah I was guessing there should be something to solve this issue. Thanks for letting us know @yrong |
No description provided.