-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support 23.0 #311
Support 23.0 #311
Conversation
Took me a while to remember why the old instrumenter needed all the tricks it had (I added one more comment to help me remember sooner next time, see 46d5f4f)... Tests are not yet finished, and tests-real are breaking on a stacktrace-related test (maybe #315 is related), although the actual reason of the failure is currently the lack of support for the Still, this (still really ugly) version might be useful to someone... |
New pain: the main tests (which are cover-enabled) are now taking too long. Unfortunately there is a LOT of redundancy there:
Still, there shouldn't be such a huge increase in time between 22.3 and 23.0... |
6dfccef
to
88422a4
Compare
e8c996a
to
07f66d5
Compare
Codecov Report
@@ Coverage Diff @@
## master #311 +/- ##
==========================================
- Coverage 95.76% 95.47% -0.29%
==========================================
Files 12 12
Lines 3682 3738 +56
==========================================
+ Hits 3526 3569 +43
- Misses 156 169 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
dfe8d9a
to
0a7e761
Compare
0a7e761
to
b0492e1
Compare
b0492e1
to
05ebdd9
Compare
Summary
This is the first commit, just to try tests on Travis and see where we are.
Besides supporting 23.0, we take out support for versions prior to 19.0
and update Travis to use xenial (Ubuntu 16.04).