This commit fixes issues #138 and #139, which were caused by missing #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cases in the utility functions for AST. This commit also makes GHC produce an error if a new AST node is added without the proper cases in Util.hs, preventing these kinds of mistakes again. To make this work there can be no "catch all" cases in the functions getChildren and putChildren. This inconvenience is outweighed by the fact that we are guaranteed to never forget adding a case for our new AST nodes. I borrowed the test case from @kikofernandez earlier pull request (that I rejected).
This was referenced Apr 27, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cases in the utility functions for AST. This commit also makes GHC
produce an error if a new AST node is added without the proper cases in
Util.hs, preventing these kinds of mistakes again. To make this work
there can be no "catch all" cases in the functions getChildren and
putChildren. This inconvenience is outweighed by the fact that we are
guaranteed to never forget adding a case for our new AST nodes.
I borrowed the test case from @kikofernandez earlier pull request (that I rejected).