Hotfix/foreach construct #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kikofernandez
commented
Apr 28, 2015
kikofernandez
commented
- Fix case where the array is of size 0
- Fix foreach node not declared in the Utils.hs
- update trace function so that it doesn't throw a warning
- remove spaces in some files
added 3 commits
April 28, 2015 09:18
fix case where the array is of size 0. it simply doesn't do anything. Update trace function by casting the `encore_actor_t` to a `pony_actor_t`.
|
Looking good! The whitespace fixes adds a bit of noise, but on the other hand we get rid of white space. |
|
Yes you are right with the white spaces. .. I thought I could put it in its own commit and not mix it with the other things. Thanks for closing the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.