Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New ponyrt #363

Merged
merged 69 commits into from
Apr 7, 2016
Merged

New ponyrt #363

merged 69 commits into from
Apr 7, 2016

Conversation

albertnetymk
Copy link
Contributor

Long awaited new ponyrt update.

@kikofernandez
Copy link
Contributor

To make this completely clear, we had to disable async's and foreach, as the tasks require some re-thinking and much more testing.

@kikofernandez
Copy link
Contributor

This PR has been rebased and I am merging in 10' unless someone opposes to this PR

Kiko Fernandez Reyes and others added 27 commits April 7, 2016 13:31
start updating compiler and normalising names
9e733d3 
start moving to the new ponyRT:

- pass the ctx argument when necessary
- refactor code: method names should be defined in CCodeNames
@albertnetymk
Update common folder from ponyrt
152bca4
@albertnetymk
Update actor folder from ponyrt
d73a108
@albertnetymk
Update gc folder from ponyrt
da1290f
@albertnetymk
Update sched folder from ponyrt
bfad929
@albertnetymk
Update future folder
af75af2
@albertnetymk
Update encore folder
05d39a8
@albertnetymk
Update rest of libponyrt from ponyrt
273be5c
@albertnetymk
Update closure folder
e862a50
@albertnetymk
Update task folder
c2e56b8
refactor ccnames and adding ctx
3726f20
update Expr.hs to use new runtime
355af53
update Closure.hs to use new runtime
fb37a07
update Function.hs to use new runtime
a19e9d7
update Header.hs to use new runtime
dbcb522
update Method.hs to use new runtime
67439c6
update array folder
da62c47
update tuple folder
6e1c5fe
update range folder
5317d1f
update array library
5a79555
update range library
d39a7bb
@albertnetymk
Update stream folder
4dd51db
@albertnetymk
Update future due to change in encore
781a0f7
add new GC.hs file
1ff0851
update party library
129a7be
small fixes on encore, task, closure and future
16d9451
small fixes to closures in parties
f610571
Kiko Fernandez Reyes and others added 21 commits April 7, 2016 13:31
move gcRecv to single function
b2f6978
add ctx to pattern matching on String type
613977c
fix ParT types
8c4622e
fix tracing on one way message send
dfae3f1
fix stream code generation
7c0834b
@albertnetymk
Drop ctx for await.
79c87c7
@albertnetymk
Drop ctx for suspend
dda53bc
@albertnetymk
Use prefix underscore for tmp variables
03ee59c
@albertnetymk
Add pony_ctx call in runtime ds constructor
1b7bcde
@albertnetymk
Expose encore_ctx to non-runtime code
884ca4e
@albertnetymk
Guard against null pointer on tracing
19403d4
@albertnetymk
Early return between batch msg process on blocking
f1fb5cb
@albertnetymk
Use OO structure for all classes
690515b
@albertnetymk
Allow bang operators on shared objects
0aa7ebe
@albertnetymk
Process batch msgs after resuming
4ae754f
@albertnetymk
Guard against losing actors on premature exit
9d0c5a8
@albertnetymk
Remove object from objectmap on release msg (bug in ponyrt?)
2a480d0
@albertnetymk
Revert back changes to task clause in dispatcher
831ed69
@albertnetymk
Call the right tracing function on sending tasks
b3da66a
update party references to ctx
df1fb0e
@albertnetymk
Disable tasks and related tests
af67e9a
@EliasC
Copy link
Contributor

EliasC commented Apr 7, 2016

I'm all for merging it! Would it possible to get a short summary of the (important) changes made to make it easier for future hackers who were not involved in this migration?

@albertnetymk
Copy link
Contributor Author

My attempt:

  • add ctx extra argument for all almost all functions to avoid calling pony_ctx()
  • realize that ctx passed as argument can't be used, for it could be obsolete due to stack manipulation in encore thread
  • use oo structure for generated code so that ctx returned from pony_ctx() could be re-used to some extent
  • small change of actor processing hooks due to msg batching in ponyrt
  • aforementioned tasks related stuff

@kikofernandez kikofernandez merged commit 57e1173 into development Apr 7, 2016
@albertnetymk albertnetymk deleted the new-ponyrt branch April 7, 2016 12:09
@EliasC
Copy link
Contributor

EliasC commented Apr 7, 2016

@albertnetymk: Does the code generation need to be aware of when the ctx argument can be used or not, or is it encapsulated in the runtime?

@albertnetymk
Copy link
Contributor Author

CG always emits the extra ctx arg, and the runtime decides to use it or not accordingly.

@EliasC
Copy link
Contributor

EliasC commented Apr 7, 2016

Sounds good! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@albertnetymk @kikofernandez @EliasC @TobiasWrigstad