Feat/web3 upgrade #181
Merged
Feat/web3 upgrade #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Velenir
commented
Nov 2, 2024
Velenir
commented
- Updating Web3 dependecny to the latest version
- Fixing a bunch of tests
size-limit report 📦
|
andriy-shymkiv
approved these changes
Nov 5, 2024
| // dynamically switch between networks configured here | ||
| // by calling `hre.switchNetwork(networkName)` thanks to hardhat-switch-network plugin | ||
| gasPrice: 8e9, | ||
| initialBaseFeePerGas: 1e10, // will break if used with a chain without eip1559 | ||
| initialBaseFeePerGas: 1e9, // will break if used with a chain without eip1559 | ||
| }, |
There was a problem hiding this comment.
as discussed, let's adjust to 1e8 to pass the tests more frequently
hardhat.config.ts
Outdated
| // which breaks web3.js | ||
| // ethers signs data and txs locally off-chain as long as it has provate key | ||
| // web3 is a bit harder to init wallets for locally. | ||
| // impersonateAccounts doesn't work, even though it should locgically fully unlock accounts, |
There was a problem hiding this comment.
Suggested change
| // impersonateAccounts doesn't work, even though it should locgically fully unlock accounts, | |
| // impersonateAccounts doesn't work, even though it should logically fully unlock accounts, |
* install ethersV6 as alias * providers/ethersV6 * distinct ethersV5 exports * legacy/support ethersV6 * simple SDK/support ethersV6 * simpleSDK.tests/add ethersV6 * partialSDK.tests/add ethersV6 * LOrders.tests/add ethersV6 * NFT_Orders.tests/add ethersV6 * update snapshots * examples/ add ethersV6 * perrDeps/update ethers versions * update snapshots * cleanup * move ethers types to provider/ethers * move web3 types to provider/web3 * untie FetchError type from AxiosError * ethers -> ethersV5, ethersV6 -> ethers to fix types when used as lib * cleanup * README/update version * less dependency on ethers types * update README * rremove temp tests * tests/ethersV6/fix derivation path arg position
Velenir
added a commit
that referenced
this pull request
Nov 12, 2024
* update some deps * replace ganache with hardhat * remove ganache * fix chainId in tests mismatch * try with tevm * tevm test * add hardhat-switch-network plugin * simplify hardhat helpers * make tests work with hardhat * fix method name * disable web3 tests that break with hardhat * fix NFT tests * remove tevm * hardhat config/explicit gasPrice * NFT tests/adjust amounts * cleanup * remove temp tests * update some deps * NFT tests/workaround some errors * update ethers dep * update web3 dep(slightly) * update deps * override some deps * Feat/web3 upgrade (#181) * update some deps * hadrhat config/smaller default baseFee * NFT tests/workaround edge case * update web3 dep * update Web3 types * update web3/constructContractCaller * legacy/update types * hardhat config/fixed accounts * LOrder tests/reenable sign with web3 * NFT Order tests/reenable sign with web3 * getBalance tests workaround * cleanup * update some deps * update snapshots * update perrDeps * update required Node v * NFT tests/account for dust * hadrhat config/lower initialBaseFeePerGas * Feat/ether v6 support (#182) * install ethersV6 as alias * providers/ethersV6 * distinct ethersV5 exports * legacy/support ethersV6 * simple SDK/support ethersV6 * simpleSDK.tests/add ethersV6 * partialSDK.tests/add ethersV6 * LOrders.tests/add ethersV6 * NFT_Orders.tests/add ethersV6 * update snapshots * examples/ add ethersV6 * perrDeps/update ethers versions * update snapshots * cleanup * move ethers types to provider/ethers * move web3 types to provider/web3 * untie FetchError type from AxiosError * ethers -> ethersV5, ethersV6 -> ethers to fix types when used as lib * cleanup * README/update version * less dependency on ethers types * update README * rremove temp tests * tests/ethersV6/fix derivation path arg position
Velenir
added a commit
that referenced
this pull request
Nov 12, 2024
* abstract away providers/findPrimaryType * add TransactionParams.maxFeeGas params * providers/viem * export from providers/viem * DEFAULT_VERSION better type * add wagmi & viem deps * SimpleSDK/viem for contractCaller * examples/viem * cleanup * examples/wagmi * tests/fix types * examples/fix types * tests/fix types * viem/fix account usage * examples/viem/fix account usage * types/TxHash=Hex * add hardhat * legacy/fix types * ignore cache files * some tests * tsconfig/allow BigInt short notation * providers/viem/reuse account * viem/fix tests * tests/viem/remove extra * tests/viem/Order signing * rename stuff * cleanup * reenable tests * tests/viem/const acc * tests/viem/update snapshots * reexport txParamsToViemTxParams * tests/viem/update snapshots * more comments * cleanup * remove extra deps * moved bignumber.js to devDeps * cleanup * update tests jpeg * update README * update snapshots * FetcherError/fix types * viem test/market swap * fix deps * update deps * update snapshots * remove dummy test * change default version * Feat/deps update/tests migration (#180) * update some deps * replace ganache with hardhat * remove ganache * fix chainId in tests mismatch * try with tevm * tevm test * add hardhat-switch-network plugin * simplify hardhat helpers * make tests work with hardhat * fix method name * disable web3 tests that break with hardhat * fix NFT tests * remove tevm * hardhat config/explicit gasPrice * NFT tests/adjust amounts * cleanup * remove temp tests * update some deps * NFT tests/workaround some errors * update ethers dep * update web3 dep(slightly) * update deps * override some deps * Feat/web3 upgrade (#181) * update some deps * hadrhat config/smaller default baseFee * NFT tests/workaround edge case * update web3 dep * update Web3 types * update web3/constructContractCaller * legacy/update types * hardhat config/fixed accounts * LOrder tests/reenable sign with web3 * NFT Order tests/reenable sign with web3 * getBalance tests workaround * cleanup * update some deps * update snapshots * update perrDeps * update required Node v * NFT tests/account for dust * hadrhat config/lower initialBaseFeePerGas * Feat/ether v6 support (#182) * install ethersV6 as alias * providers/ethersV6 * distinct ethersV5 exports * legacy/support ethersV6 * simple SDK/support ethersV6 * simpleSDK.tests/add ethersV6 * partialSDK.tests/add ethersV6 * LOrders.tests/add ethersV6 * NFT_Orders.tests/add ethersV6 * update snapshots * examples/ add ethersV6 * perrDeps/update ethers versions * update snapshots * cleanup * move ethers types to provider/ethers * move web3 types to provider/web3 * untie FetchError type from AxiosError * ethers -> ethersV5, ethersV6 -> ethers to fix types when used as lib * cleanup * README/update version * less dependency on ethers types * update README * rremove temp tests * tests/ethersV6/fix derivation path arg position
Velenir
added a commit
that referenced
this pull request
Nov 12, 2024
* update build dependencies * update tsconfig * actions/remove Node18 * fix types * extra gitignore * update typedoc deps * update snapshots * fix dependencies * Feat/viem support (#174) * abstract away providers/findPrimaryType * add TransactionParams.maxFeeGas params * providers/viem * export from providers/viem * DEFAULT_VERSION better type * add wagmi & viem deps * SimpleSDK/viem for contractCaller * examples/viem * cleanup * examples/wagmi * tests/fix types * examples/fix types * tests/fix types * viem/fix account usage * examples/viem/fix account usage * types/TxHash=Hex * add hardhat * legacy/fix types * ignore cache files * some tests * tsconfig/allow BigInt short notation * providers/viem/reuse account * viem/fix tests * tests/viem/remove extra * tests/viem/Order signing * rename stuff * cleanup * reenable tests * tests/viem/const acc * tests/viem/update snapshots * reexport txParamsToViemTxParams * tests/viem/update snapshots * more comments * cleanup * remove extra deps * moved bignumber.js to devDeps * cleanup * update tests jpeg * update README * update snapshots * FetcherError/fix types * viem test/market swap * fix deps * update deps * update snapshots * remove dummy test * change default version * Feat/deps update/tests migration (#180) * update some deps * replace ganache with hardhat * remove ganache * fix chainId in tests mismatch * try with tevm * tevm test * add hardhat-switch-network plugin * simplify hardhat helpers * make tests work with hardhat * fix method name * disable web3 tests that break with hardhat * fix NFT tests * remove tevm * hardhat config/explicit gasPrice * NFT tests/adjust amounts * cleanup * remove temp tests * update some deps * NFT tests/workaround some errors * update ethers dep * update web3 dep(slightly) * update deps * override some deps * Feat/web3 upgrade (#181) * update some deps * hadrhat config/smaller default baseFee * NFT tests/workaround edge case * update web3 dep * update Web3 types * update web3/constructContractCaller * legacy/update types * hardhat config/fixed accounts * LOrder tests/reenable sign with web3 * NFT Order tests/reenable sign with web3 * getBalance tests workaround * cleanup * update some deps * update snapshots * update perrDeps * update required Node v * NFT tests/account for dust * hadrhat config/lower initialBaseFeePerGas * Feat/ether v6 support (#182) * install ethersV6 as alias * providers/ethersV6 * distinct ethersV5 exports * legacy/support ethersV6 * simple SDK/support ethersV6 * simpleSDK.tests/add ethersV6 * partialSDK.tests/add ethersV6 * LOrders.tests/add ethersV6 * NFT_Orders.tests/add ethersV6 * update snapshots * examples/ add ethersV6 * perrDeps/update ethers versions * update snapshots * cleanup * move ethers types to provider/ethers * move web3 types to provider/web3 * untie FetchError type from AxiosError * ethers -> ethersV5, ethersV6 -> ethers to fix types when used as lib * cleanup * README/update version * less dependency on ethers types * update README * rremove temp tests * tests/ethersV6/fix derivation path arg position
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.