Introduce "bundler" feature flag #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinedufn
commented
Dec 11, 2022
| @@ -26,6 +26,14 @@ name = "lightningcss" | |||
| path = "src/lib.rs" | |||
| crate-type = ["rlib"] | |||
|
|
|||
| [features] | |||
There was a problem hiding this comment.
Moved the feature flags up since they're commonly found above the dependencies section.
When evaluating a crate I find it nice to be able to quickly see what features I can turn off.
Happy to move them back if you prefer!
This commit adds a "bundler" feature flag to the lightningcss crate. We put the "dashmap" and "rayon" dependencies behind this new flag. Users that do not need the bundler can now disable the feature to save on compile time. Related: parcel-bundler#357
chinedufn
force-pushed
the
feature-flag-bundler
branch
from
84a6b2f
to
b402eb8
Compare
devongovett
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a "bundler" feature flag to the lightningcss crate.
We put the "dashmap" and "rayon" dependencies behind this new flag.
Users that do not need the bundler can now disable the feature to save
on compile time.
Related: #357