Introduce "visitor" feature flag #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinedufn
force-pushed
the
visitor-derive-feature-flag
branch
2 times, most recently
from
8d73eee to
870c006
Compare
This commit adds a "visitor" feature flag to the lightningcss crate. This feature flag controls whether or not the `Visitor` trait gets compiled. The "visitor" flag is disabled by default. Disabling the "visitor" feature disables the `lightningcss-derive` dependency. This commit on its own reduces the lightningcss crate's build time by about 8% (as measured by comparing `cargo build --timings` with and without the "visitor" feature enabled. When combined with some of the other soon to land commits, this commit will make it possible to remove `syn` from the dependency tree when you don't need it, which should lead to substantial compile time savings. Related: parcel-bundler#357
chinedufn
force-pushed
the
visitor-derive-feature-flag
branch
from
870c006 to
118b4a3
Compare
…into visitor-derive-feature-flag # Conflicts: # Cargo.toml # src/dependencies.rs
devongovett
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a "visitor" feature flag to the lightningcss crate.
This feature flag controls whether or not the
Visitortrait getscompiled. The "visitor" flag is disabled by default.
Disabling the "visitor" feature disables the
lightningcss-derivedependency.
This commit on its own reduces the lightningcss crate's build time by
about 8% (as measured by comparing
cargo clean && cargo build --timingswith andwithout the "visitor" feature enabled.
When combined with some of the other soon to land commits, this commit
will make it possible to remove
synfrom the dependency tree when youdon't need it, which should lead to substantial compile time savings.
Related: #357