Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scoped modules #1013

Merged
merged 2 commits into from
Mar 18, 2018
Merged

Fix scoped modules #1013

merged 2 commits into from
Mar 18, 2018

Conversation

fathyb
Copy link
Contributor

@fathyb fathyb commented Mar 17, 2018

#850 doesn't support scoped modules, ie. @angular/core

  • Windows

@devongovett devongovett added this to the v1.7.0 milestone Mar 17, 2018
@fathyb fathyb added the 📝 WIP Work In Progress label Mar 18, 2018
@devongovett devongovett removed the 📝 WIP Work In Progress label Mar 18, 2018
Copy link
Member

@devongovett devongovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I fixed it on windows.

@codecov-io
Copy link

codecov-io commented Mar 18, 2018

Codecov Report

Merging #1013 into master will increase coverage by 1.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1013      +/-   ##
==========================================
+ Coverage   89.06%   90.18%   +1.12%     
==========================================
  Files          68       68              
  Lines        3438     3272     -166     
==========================================
- Hits         3062     2951     -111     
+ Misses        376      321      -55
Impacted Files Coverage Δ
src/Resolver.js 100% <100%> (ø) ⬆️
src/transforms/posthtml.js 80.48% <0%> (-19.52%) ⬇️
src/assets/ReasonAsset.js 91.66% <0%> (-8.34%) ⬇️
src/visitors/dependencies.js 80.51% <0%> (-6.5%) ⬇️
src/assets/CSSAsset.js 86.08% <0%> (-4.35%) ⬇️
src/utils/installPackage.js 61.9% <0%> (-3.18%) ⬇️
src/assets/HTMLAsset.js 85.1% <0%> (-2.13%) ⬇️
src/assets/CoffeeScriptAsset.js 100% <0%> (ø) ⬆️
src/assets/TOMLAsset.js 100% <0%> (ø) ⬆️
src/assets/GraphqlAsset.js 100% <0%> (ø) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c469751...0960d0c. Read the comment docs.

@devongovett devongovett merged commit 9488fc6 into master Mar 18, 2018
@devongovett devongovett deleted the fix/scoped-modules branch March 18, 2018 03:13
devongovett pushed a commit that referenced this pull request Oct 15, 2018
devongovett pushed a commit that referenced this pull request Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants