Minimal verbose mode #1834
Merged
Minimal verbose mode #1834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fathyb
approved these changes
Aug 16, 2018
devongovett
reviewed
Aug 23, 2018
src/cli.js
Outdated
| @@ -59,7 +59,7 @@ program | |||
| .option( | |||
| '--log-level <level>', | |||
| 'set the log level, either "0" (no output), "1" (errors), "2" (warnings + errors) or "3" (all).', | |||
There was a problem hiding this comment.
Should we update this message to add the new verbose modes?
There was a problem hiding this comment.
Probably, updated it to include the verbose and debug mode
devongovett
reviewed
Aug 23, 2018
src/Logger.js
Outdated
| `parcel-debug-${currDate.toLocaleDateString()}@${currDate.toLocaleTimeString()}.log` | ||
| ) | ||
| ); | ||
| this.logFile.write = this.logFile.write.bind(this.logFile); |
There was a problem hiding this comment.
Don't think so, I'll remove it, seems to work fine without
devongovett
approved these changes
Aug 23, 2018
Merged
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
codeaholicguy
added a commit
to codeaholicguy/website
that referenced
this pull request
Oct 25, 2018
Follow parcel-bundler/parcel#1834 I add `verbose` and `debug` options to log level
DeMoorJasper
pushed a commit
to parcel-bundler/website
that referenced
this pull request
Oct 25, 2018
Follow parcel-bundler/parcel#1834 I add `verbose` and `debug` options to log level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds verbose and debug mode:
4: verbose, keep everything in log with timestamps, instead of using statusspinner
5: debug, save everything to a file with timestamps
Shouldn't slow down anything, verbose might even speed everything up as it uses native console.log instead of a spinner.
Also adds a log call after an asset has been processed to track which files are being successfully built
Closes #993