Fix non-updating asset hashes #1861
Conversation
DeMoorJasper
changed the title
src/Asset.js
Outdated
| let contentHash = ''; | ||
| try { | ||
| contentHash = md5(this.contents); | ||
| } catch (err) { |
There was a problem hiding this comment.
In case this.contents is not a string or undefined
|
Maybe the hash should be based on the contents after post processing instead of generate also? That seems to be related to this issue. |
|
So moving hash generation to the Pipeline after postProcess? Or just merging the asset hash with postProcessed output hash? |
|
Yeah I guess? I'd say just hash the original content but sometimes we don't actually read it (so you have the try..catch). Try just hashing the post-processed output instead of generate and see if that fixes the bug. |
|
Changed it, should still fix the issue. As it's pretty much doing the same. Just on output instead of input. (which is probably more reliable for virtual assets like globs) |
src/Asset.js
Outdated
| @@ -214,7 +213,7 @@ class Asset { | |||
| } | |||
|
|
|||
| generateHash() { | |||
There was a problem hiding this comment.
Is this method needed anymore?
There was a problem hiding this comment.
RawAsset uses it as it has no generated content
There was a problem hiding this comment.
Maybe we should keep the method then and just call it after post-processing is done?
|
Looks like the tests are failing because the yarn lockfile is pointing at adobe corp artifactory. Can you fix? |
|
@devongovett I think it ended up in the master branch by accident, can't seem to find it in this branch. Appears to be the flow deps, I'll open a seperate PR to fix that |
Include asset content in asset hash, as generated not always outputs the entire ast and makes it unreliable. (Only content would probably also be unreliable)
Should prevent some cases where assets don't get updated either from cache or HMR
Closes #1789