[WIP] Support to rust/wasm #312

albizures · 2017-12-16T22:31:01Z

Hi, this PR is not complete yet, currently, I'm struggling with two things:

the first one is when there is a change in the entry rust file, the new wasm file is being generated but the file in the build folder doesn't change. I think it's something related to the cache.
and the second one is related to the secondary rust files when there is a change in these files parcel doesn't detect the change. I think I have to do something like in StylusAssets, use a custom evaluator, but I'm not sure.

Any ideas?

Thanks in advance

related: #34

devongovett · 2017-12-17T05:56:26Z

Awesome start, really excited about this! I'll give some more feedback in a bit! 🎉

softprops · 2017-12-19T02:46:08Z

Awesome to find some one is already working on this. So fast!

devongovett

Great start! Left some suggestions inline.

devongovett · 2017-12-19T09:12:18Z

src/assets/RustAsset.js

+const JSAsset = require('./JSAsset');
+const localRequire = require('../utils/localRequire');
+
+const rustTarget = `wasm32-unknown-emscripten`;


I think maybe we'll want to use wasm32-unknown-unknown, which doesn't require emscripten. Maybe checkout rustify which does something similar for browserify, and wasm-experiments to see how it all works.

right now I'm using wargo and for now, wargo just uses wasm32-unknown-emscripten

but sure, I'm going to take a look at rustify

devongovett · 2017-12-19T09:12:34Z

src/assets/RustAsset.js

+    this.dependencies.clear();
+    const {name, encoding, options} = this;
+    const release = process.env.NODE_ENV === 'production';
+    const cmd = `wargo build ${release ? ' --release' : ''}`;


did you mean cargo?

no, wargo is a library that setup your environment and makes easy to compile rust into wasm

Does this PR verify that wargo is installed and accessible or fail violently?

right now it's failing violently, 😄 but I was working on an api more friendly to use wargo directly instead of using wargo through child_process.
However, I was thinking about to stop using wargo since wargo is using wasm32-unknown-emscripten and I think wasm32-unknown-unknown is a better option...

devongovett · 2017-12-19T09:13:38Z

src/assets/RustAsset.js

+
+const rustTarget = `wasm32-unknown-emscripten`;
+
+class RustAsset extends JSAsset {


I think we should probably make a WASMAsset class to load precompiled .wasm files, and use it as a base class for this one. That way the runtime can be shared across multiple wasm languages.

devongovett · 2017-12-19T09:13:57Z

src/assets/RustAsset.js

+  async parse(code) {
+    this.invalidateBundle();
+    this.invalidate();
+    this.dependencies.clear();


why is this necessary?

oh my bad, this was me trying to fix the rebuild as mentioned in the description, I'll remove it, thanks

devongovett · 2017-12-19T09:15:08Z

src/assets/RustAsset.js

+      ENVIRONMENT: 'WEB'
+    };
+
+    if (options.fromHtml) {


Why is it different when loaded from HTML?

the difference is that with this approach you can use rust as a standalone executable, without javascript.

I got the idea from this article

shawwn · 2017-12-21T00:41:48Z

Hey, I can set aside some time over the holidays to help finish the PR if you'd like. If you want a hand, ping me in parcel's Slack.

albizures · 2017-12-21T01:23:07Z

Sure thing @shawwn thanks!

get rid of wargo use wasm32-unknown-unknown

albizures · 2017-12-23T06:08:26Z

Hey @devongovett, I made some changes

So, I got rid of wargo, and now I'm using wasm32-unknown-unknown directly also these changes fix my first point in the description 🎉

what is next?

tackle my second point in the description
validate the existence of rustc, wasm32-unknown-unknown target and create a useful alert
use wasm-gc, in production mode, if it exists

Do you have something else in mind?

also, I made a demo

cc: @shawwn

devongovett · 2017-12-26T04:48:28Z

🎉 Awesome work @albizures! Your list sounds good.

I think you can use rustc to determine the list of imported files: use the --emit dep-info flag and it will generate a file with all the deps in it that we could parse. These can be sent to parcel as dependencies with the includedInParent: true flag, which will cause parcel to watch those files but not try to parse them as they've already been compiled by rust.

About validating the existence of rustc, I wonder if we could just install it for you if you don't have it installed. Especially since we depend on the nightly toolchain, a specific backend (wasm32-unknown-unknown), and wasm-gc, we could just install those for you if they aren't already. We do this for other compilers like typescript, but it's slightly easier since those are in npm.

Also, we should probably support using cargo build rather than rustc directly, if we detect a Cargo.toml file. This will allow some more complex builds to happen. Not sure if we can detect dependencies in that case though.

Let's also start thinking about what we want the API for importing wasm modules to be. I think there should be a small runtime built into Parcel to load and instantiate wasm modules. Basically we should take care of the WebAssembly.instantiate call and the import should resolve to instance.exports.

There are two cases to think about.

Synchronous import, wasm is either inlined into JS or somehow loaded prior to the JS running:

import {add} from './add.rs';

console.log(add(2, 3));

Asynchronous import, wasm is placed in a separate file and loaded on demand:

let {add} = await import('./add.rs');

console.log(add(2, 3));

Sorry for the long comment. All of this definitely doesn't need to happen in this PR, just getting the ideas flowing! 😄

devongovett · 2017-12-26T22:38:04Z

Going to merge this into the wasm branch on the main repo. I've added you as a collaborator @albizures so you should be able to work off that branch.

albizures · 2017-12-27T00:04:41Z

oh great, thanks 🎉

and I agree with you with all of your points.

I'll let you know any news

albizures added 2 commits December 16, 2017 14:50

add support to rust/wasm

127274a

use child-process-promise instead of async-child-process

1afd49d

albizures mentioned this pull request Dec 16, 2017

WebAssembly Support #34

Closed

albizures mentioned this pull request Dec 18, 2017

🐛 Problem with loading manifest.json #235

Closed

brandon93s changed the title ~~Support to rust/wasm~~ [WIP] Support to rust/wasm Dec 19, 2017

albizures mentioned this pull request Dec 19, 2017

Node friendly api lord/wargo#23

Open

devongovett requested changes Dec 19, 2017

View reviewed changes

use parent extension instead of fromHtml flag

588ba44

albizures added 5 commits December 20, 2017 21:04

Merge branch 'master' of https://github.com/parcel-bundler/parcel

35f836e

create WasmAsset

5838a4e

RustAsset refactor

0012704

get rid of wargo use wasm32-unknown-unknown

Merge branch 'master' of https://github.com/parcel-bundler/parcel

804fc97

fix lint errors, remove toml package and delete jsconfig.json

1360713

devongovett changed the base branch from master to wasm December 26, 2017 22:36

devongovett merged commit 1f09abb into parcel-bundler:wasm Dec 26, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Support to rust/wasm #312

[WIP] Support to rust/wasm #312

albizures commented Dec 16, 2017

devongovett commented Dec 17, 2017

softprops commented Dec 19, 2017

devongovett left a comment

devongovett Dec 19, 2017

albizures Dec 19, 2017

devongovett Dec 19, 2017

albizures Dec 19, 2017

phrohdoh Dec 20, 2017

albizures Dec 20, 2017

devongovett Dec 19, 2017

devongovett Dec 19, 2017

albizures Dec 19, 2017

devongovett Dec 19, 2017

albizures Dec 19, 2017

shawwn commented Dec 21, 2017

albizures commented Dec 21, 2017

albizures commented Dec 23, 2017

devongovett commented Dec 26, 2017

devongovett commented Dec 26, 2017

albizures commented Dec 27, 2017


		const rustTarget = `wasm32-unknown-emscripten`;

		class RustAsset extends JSAsset {

[WIP] Support to rust/wasm #312

[WIP] Support to rust/wasm #312

Conversation

albizures commented Dec 16, 2017

devongovett commented Dec 17, 2017

softprops commented Dec 19, 2017

devongovett left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shawwn commented Dec 21, 2017

albizures commented Dec 21, 2017

albizures commented Dec 23, 2017

devongovett commented Dec 26, 2017

devongovett commented Dec 26, 2017

albizures commented Dec 27, 2017